chore: add per_page parameter to page #301
Merged
+186
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
feloy
and removed request for
a team
benoitf
reviewed
Feb 19, 2025
src/lib/ui/ExtensionsList.svelte
Outdated
| let showCategories = true; | ||
|
|
||
| // Get the query from the URL | ||
| function getQueryLimit(): number | null { |
There was a problem hiding this comment.
issue: null is not authorized (I was assuming we got a lint rule for that)
---> undefined
| <ExtensionsByCategory {extensionByCategoryInfo} /> | ||
| {/each} | ||
| {#if showCategories} | ||
| {#each extensionsByCategories as extensionByCategoryInfo} |
There was a problem hiding this comment.
issue (non blocking) but not sure why: looks like we have existing tab characters
There was a problem hiding this comment.
hmm, looks like pnpm format:fixdoes not actually do svelte files too
cdrage
force-pushed
the
add-query
branch
2 times, most recently
from
6f0bf0c to
746d7ea
Compare
feloy
reviewed
Feb 24, 2025
src/lib/ui/ExtensionsList.svelte
Outdated
| import ExtensionsByCategory from './ExtensionsByCategory.svelte'; | ||
|
|
||
| const { extensionsByCategories }: { extensionsByCategories: ExtensionByCategoryInfo[] } = $props(); | ||
| export let extensionsByCategories: ExtensionByCategoryInfo[]; |
There was a problem hiding this comment.
why are you reverting to svelte 4?
There was a problem hiding this comment.
will fix, bad habit using svelte 4 for everything haha!
jeffmaury
reviewed
Feb 25, 2025
Updated to |
jeffmaury
approved these changes
Mar 3, 2025
cdrage
changed the title
Updated the PR commit title and description + the actual commit now. Thanks! |
Adds per_page parameter to the page. If you pass in ?per_page=4 into the URL, it'll show only the last 4 updated extensions. Open for suggestions on other names for it. Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add per_page parameter to page
Adds per_page parameter to the page.
If you pass in ?per_page=4 into the URL, it'll show only the last 4 updated
extensions.
Open for suggestions on other names for it.
Closes #192
Signed-off-by: Charlie Drage charlie@charliedrage.com