Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add per_page parameter to page #301

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Feb 19, 2025

chore: add per_page parameter to page

Adds per_page parameter to the page.

If you pass in ?per_page=4 into the URL, it'll show only the last 4 updated
extensions.

Open for suggestions on other names for it.

Screenshot 2025-02-19 at 12 47 25 PM

Closes #192

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested review from benoitf and a team as code owners February 19, 2025 17:46
@cdrage cdrage requested review from jeffmaury and feloy and removed request for a team February 19, 2025 17:46
let showCategories = true;

// Get the query from the URL
function getQueryLimit(): number | null {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: null is not authorized (I was assuming we got a lint rule for that)
---> undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops! old habits

<ExtensionsByCategory {extensionByCategoryInfo} />
{/each}
{#if showCategories}
{#each extensionsByCategories as extensionByCategoryInfo}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (non blocking) but not sure why: looks like we have existing tab characters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, looks like pnpm format:fixdoes not actually do svelte files too

@cdrage cdrage force-pushed the add-query branch 2 times, most recently from 6f0bf0c to 746d7ea Compare February 20, 2025 17:04
import ExtensionsByCategory from './ExtensionsByCategory.svelte';

const { extensionsByCategories }: { extensionsByCategories: ExtensionByCategoryInfo[] } = $props();
export let extensionsByCategories: ExtensionByCategoryInfo[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you reverting to svelte 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix, bad habit using svelte 4 for everything haha!

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name proposition: per_page (as per GitHub API) query is to vague for me

@cdrage
Copy link
Contributor Author

cdrage commented Feb 26, 2025

Name proposition: per_page (as per GitHub API) query is to vague for me

Updated to per_page

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title and description to be updated

@cdrage cdrage changed the title chore: add query parameter to page chore: add per_page parameter to page Mar 3, 2025
@cdrage
Copy link
Contributor Author

cdrage commented Mar 3, 2025

Title and description to be updated

Updated the PR commit title and description + the actual commit now. Thanks!

cdrage added 2 commits March 3, 2025 09:17
Adds per_page parameter to the page.

If you pass in ?per_page=4 into the URL, it'll show only the last 4 updated
extensions.

Open for suggestions on other names for it.

Signed-off-by: Charlie Drage <[email protected]>
Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage enabled auto-merge (squash) March 3, 2025 14:17
@cdrage cdrage merged commit ff0c13e into podman-desktop:main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query parameters to list last 4 updated extensions
4 participants